Data flow: Replace getErasedRepr() and Node::getTypeBound() with getNodeType()#3854
Merged
aschackmull merged 4 commits intogithub:masterfrom Jul 1, 2020
Merged
Conversation
hvitved
force-pushed
the
dataflow/node-type-interface
branch
from
81b9a4b to
8c525b8
Compare
hvitved
force-pushed
the
dataflow/node-type-interface
branch
from
8c525b8 to
f1179cc
Compare
aschackmull
approved these changes
Jul 1, 2020
Contributor
Author
|
(cc @jbj, @MathiasVP : This means that you can now remove/deprecate |
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Jul 1, 2020
…`getNodeType()`. cf github/codeql#3854
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Jul 2, 2020
…`getNodeType()`. cf github/codeql#3854
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the interface to the shared data-flow library by combining
getErasedRepr()andNode::getTypeBound()to a singlegetNodeType()predicate.This means that we no longer require
getTypeBound()to be exposed via the public classNode, and it has consequently been removed for C# (it was already marked with anINTERNALcomment). The predicates are still there for C++ and Java, and they will have to be deprecated before removal, but I'll let the C++ and Java teams decide on that.